Go back to using ref callback instead of useImperativeHandle #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
yungsters
reviewed
Aug 5, 2025
packages/react-strict-dom/src/native/modules/useStrictDOMElement.js
Outdated
Show resolved
Hide resolved
necolas
force-pushed
the
native/null-handle
branch
from
3cb0a57 to
083f2a6
Compare
yungsters
reviewed
Aug 5, 2025
Comment on lines
+46
to
+117
| const elementCallback = useElementCallback( | ||
| React.useCallback( |
There was a problem hiding this comment.
I don't think you need useElementCallback here.
The useCallback already has ref as a dependency, which means the function returned by useCallback will already be invalidated if ref changes. And when that new function is passed into the native component's ref prop below, it will naturally detach the previous one and attach the new one.
yungsters
reviewed
Aug 5, 2025
packages/react-strict-dom/src/native/modules/useStrictDOMElement.js
Outdated
Show resolved
Hide resolved
necolas
force-pushed
the
native/null-handle
branch
from
083f2a6 to
95ab62e
Compare
necolas
changed the title
We shouldn't create an object if the underlying node is null, as this handle is meant to emulate the node but can't proxy methods if none exist. Since useImperativeHandle isn't reset when the underlying node changes, we go back to using ref callbacks. Rather than mutating the underling node, we create a new object that wraps the relevant fields.
necolas
force-pushed
the
native/null-handle
branch
from
95ab62e to
d9f8e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't create an object if the underlying node is null, as this handle is meant to emulate the node but can't proxy methods if none exist.